MediaWiki:Gadget-QuickPresets.js - Revision history

Stenli karanxha at 12:13, 12 January 2020

2020-01-12T12:13:20Z

2020-01-12T12:09:35Z

2020-01-12T11:36:31Z

2020-01-12T11:34:17Z

2020-01-12T11:19:42Z

Undo revision 74593 by Stenli karanxha (talk)

2020-01-12T11:19:15Z

Undo revision 74596 by Stenli karanxha (talk)

2020-01-12T11:18:42Z

2020-01-12T11:16:42Z

Removed a bug at passing headers to the fetch request

2020-01-12T11:07:54Z

Added 2 semicolons, removed a line feed.

2020-01-07T16:36:15Z

@@ Line 209: / Line 209: @@
        fetch(fullUrl, { headers: myHeaders })
          .then(function(body) {body.json();})
-         .then(function(json) {if (json.boolean) {quickpresets_addinterface(qid, prop);}});
+         .then(function(json) {if (json && json.boolean) {quickpresets_addinterface(qid, prop);}});
+     }
+   }

@@ Line 173: / Line 173: @@
   */
 function quickpresets_checktype(qid, prop) {
-	var typeqid=prop.qid;
+  var typeqid = prop.qid;
-    // Search in HTML-DOM
+  // Search in HTML-DOM
-    // for each "instance of" value, run this function
+  // for each "instance of" value, run this function
-    var typefromdom=$.map($('#P3').find(".wikibase-snakview-value a"), function(value, index) {
+  var typefromdom = $.map($("#P3").find(".wikibase-snakview-value a"), function(
-	if(typeof value.attributes.href === "undefined")
+    value,
+    index
-	        return [];
+  ) {
+    if (typeof value.attributes.href === "undefined") {
-	else
+      return [];
+    } else {
-	        return [value.attributes.href.value.substring(6)];
+      return [value.attributes.href.value.substring(6)];
+     }
-    else {
+  });
-	     if ( typeqid === 0 ) {
+  // typefromdom is now a list of Item:Qxxx, possibly empty
-	     	// the 0 prescription, applicable to all items which are instance of something
+  if (typefromdom.length === 0) {
-		    quickpresets_addinterface(qid, prop);
+    if (typeqid === null) {
+      // the null prescription for when there is no "instance of"
-	    else if ( typefromdom.includes("Item:Q"+typeqid) ) {
+      quickpresets_addinterface(qid, prop);
+     }
+}

@@ Line 210: / Line 210: @@
 		    headers = { 'Accept': 'application/sparql-results+json' };
 		    debug("qid: "+ qid + "\ntypeqid: " + typeqid + "\n" + fullUrl + "\n" + sparqlQuery);
-	        fetch( fullUrl, { headers: { 'Accept': 'application/sparql-results+json' } } )
+	        fetch( fullUrl, { headers: { 'Accept': 'application/sparql-results+json' }, } )
-	        	.then( body => body.json() )
+	        	.then( body => { body.json() } )
 	        	.then( json => { if ( json.boolean ) quickpresets_addinterface(qid, prop); } );
+	    }

@@ Line 210: / Line 210: @@
 		    headers = { 'Accept': 'application/sparql-results+json' };
 		    debug("qid: "+ qid + "\ntypeqid: " + typeqid + "\n" + fullUrl + "\n" + sparqlQuery);
-	        fetch( fullUrl, { headers } ).then( body => body.json() ).then( json => {
+	        fetch( fullUrl, { headers: { 'Accept': 'application/sparql-results+json' } } )
-		    if ( json.boolean )
+	        	.then( body => body.json() )
-		        quickpresets_addinterface(qid, prop);
+	        	.then( json => { if ( json.boolean ) quickpresets_addinterface(qid, prop); } );
+	    }
+     }

@@ Line 208: / Line 208: @@
 		    sparqlQuery = 'Ask { pdio:Q' + qid + ' pdiot:P3/pdiot:P4* pdio:Q' + typeqid + '. hint:Prior hint:gearing "forwards" }',
 		    fullUrl = endpointUrl + '?query=' + encodeURIComponent( sparqlQuery ),
-		    myHeaders = { 'Accept': 'application/sparql-results+json' };
+		    headers = { 'Accept': 'application/sparql-results+json' };
 		    debug("qid: "+ qid + "\ntypeqid: " + typeqid + "\n" + fullUrl + "\n" + sparqlQuery);
-	        fetch( fullUrl, { headers:myHeaders } ).then( body => body.json() ).then( json => {
+	        fetch( fullUrl, { headers } ).then( body => body.json() ).then( json => {
 		    if ( json.boolean )
 		        quickpresets_addinterface(qid, prop);

@@ Line 7: / Line 7: @@
 // see doc at [[Gadget-QuickPresets/doc]]
-mw.notify("QuickPresets")
+// mw.notify("QuickPresets")
 function debug(alert){
 	// mw.notify(alert)